Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactoring of QR: stabilized Gram-Schmidt for split=1 and TS-QR for …
…split=0 (#1329) * added file `myqr.py` that contains experiment in direction blockwise stabilized GS for QR (split=1) * Update __init__.py * removed `myrandn` since `randn` is fixed meanwhile * ... * replaced previour QR implementation by the new one * ... * refactoring * ... * added some unit tests for the refactored qr with split=1 * ... * resolved some bugs related to calc_q, calc_r etc. * removed option overwrite_a * extended comments in the code * ... * removed strange option full_q (should be addressed somewhere else later) * formatting of warning * adapted API of new qr to follow the one in numpy * first version of split=0 (TS-QR), stil with bugs * fixed some bugs, some others are stil there... * fixed some bugs: a problem was, e.g., that torch's qr returns non-contiguous q and r even if input was contiguous * still errors but I dont find them... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * found bugs in TS-QR, now we should have a running version TODOS: extend comments (to have maintainable code), check ROCm-support, unittests for wrong inpus/errors * removed skip from some svd_tests on AMD (they were introduced due to missing QR support) added tests for catching wrong inputs in QR slightly extended docs of QR * Update test_matrixgallery.py removed skips for AMD devices * Update linalg.py modified continuous benchmarks for new qr implementation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linalg.py removed bug in benchmarks * resolved first parts of the comments in the review * updated docs of refactored QR since no batches of matrices are supported * modified docs according to review * removed "from time import sleep", completed dead end sentence in docs --------- Co-authored-by: Hoppe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Claudia Comito <[email protected]>