Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace factories.array() with DNDarray construct #1138

Conversation

saivythik
Copy link

Description

Issue/s resolved: #
enhancement

Changes proposed:

-change proposed by ClaudiaComito

Type of change

enhancement

Memory requirements

Performance

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

yes / no

@saivythik saivythik force-pushed the enhancement/799-manipulations branch from 43dfa32 to e050560 Compare April 2, 2023 18:42
@ClaudiaComito
Copy link
Contributor

@saivythik apologies for the delay in reviewing. This PR is unfinished. If you're still interested, please reply here and I'll get into more details as to what needs to be done.

If we don't hear from you within a week, we'll close the PR.

Thanks again for your time.

@ClaudiaComito ClaudiaComito marked this pull request as draft August 18, 2023 17:38
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 11, 2023
@ClaudiaComito
Copy link
Contributor

we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants