Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release v1.3.1 into main #1278

Merged
merged 19 commits into from
Nov 23, 2023

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Nov 23, 2023

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

  • Merging latest release and updating CHANGELOG.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

JuanPedroGHM and others added 19 commits October 31, 2023 15:28
The copy of tzdata was originally intended to be used from the root
of the repository. The documentation states building docker images
from the docker directory. This had to be aligned.

Moreover, each RUN line in a Dockerfile represents the building of
another intermediate image. This has to be taken into account when
writing the files. Commands such as "cd" will not work on separate
lines.
* upgrade checkout action & use default token

* increase tolerance for single-prec torch.inv comparison

* fix typo

---------

Co-authored-by: Claudia Comito <[email protected]>
…-hiccup

Increase tolerance for `ht.allclose` on `ht.inv` operations for all torch versions
…e-commit-config

Sync `pre-commit` configuration with `main` branch
…o_does_not_work_on_GPU

Bug-fix for lasso on GPU
* fix diff axis size one

* fix diff() axis along split

* remove debug code

---------

Co-authored-by: Claudia Comito <[email protected]>
* update version to 1.3.1 before release

* revert

* update version before release
@ghost
Copy link

ghost commented Nov 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ClaudiaComito ClaudiaComito added this to the 1.4.0 milestone Nov 23, 2023
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5125ccc) 91.83% compared to head (5864266) 91.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1278   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          77       77           
  Lines       11191    11193    +2     
=======================================
+ Hits        10277    10279    +2     
  Misses        914      914           
Flag Coverage Δ
unit 91.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClaudiaComito ClaudiaComito merged commit 3302a44 into main Nov 23, 2023
78 checks passed
@ClaudiaComito ClaudiaComito deleted the workflows/merge-latest-release-into-main branch November 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants