Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workflow to monitor stale issues/PRs #1283

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Nov 24, 2023

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

adds a workflow for inactive issues and pr for more than 60 days and closes them after 60 additional days.

Issue/s resolved: #1282

Changes proposed:

  • Create worflow inactivity.yml using actions/stable action

Type of change

  • workflow

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the workflows label Nov 24, 2023
@mtar mtar requested a review from ClaudiaComito November 24, 2023 13:35
@mtar mtar changed the title Create inactivity.yml Close inactive issue / pr Nov 24, 2023
@ghost
Copy link

ghost commented Nov 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b87890) 91.82% compared to head (63d92cd) 91.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1283   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          79       79           
  Lines       11457    11457           
=======================================
  Hits        10520    10520           
  Misses        937      937           
Flag Coverage Δ
unit 91.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtar! Looks good, just a few comments.

name: Close inactive issues
on:
schedule:
- cron: "30 1 * * *"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once a week should be enough, what do you think? Monday night, so we have a fresh batch of stale stuff before the PR call?

.github/workflows/inactivity.yml Outdated Show resolved Hide resolved
.github/workflows/inactivity.yml Outdated Show resolved Hide resolved
.github/workflows/inactivity.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looking forward to Monday!

@ClaudiaComito ClaudiaComito changed the title Close inactive issue / pr Implement stale issue/PR workflow Nov 27, 2023
@ClaudiaComito ClaudiaComito changed the title Implement stale issue/PR workflow Implement workflow to moniotr stale issues/PRs Nov 27, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering The Matrix again

@mtar mtar changed the title Implement workflow to moniotr stale issues/PRs Implement workflow to monitor stale issues/PRs Nov 27, 2023
@ClaudiaComito ClaudiaComito merged commit aa24cc6 into main Nov 30, 2023
7 of 79 checks passed
@mtar mtar deleted the workflows/1282-label_stale_issues_/_pull_request branch February 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

label stale issues / pull request
2 participants