Update pytorch release PR workflow #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.3.x #1286 +/- ##
==============================================
Coverage 92.17% 92.17%
==============================================
Files 75 75
Lines 10705 10705
==============================================
Hits 9867 9867
Misses 838 838
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClaudiaComito
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
If I understand this correctly, the workflow must be triggered manually both on main and on the release branch(es). On the other hand, no further (manual) update of the branch name is necessary.
It looks good to me, it's a good compromise. Thanks a lot @mtar !
|
Thank you for the PR! |
Yes, you have to select the branch before manually triggering it. |
ClaudiaComito
deleted the
enhancement/1241-new-pytorch-release-workflow
branch
mtar
added a commit
that referenced
this pull request
Jan 3, 2024
* add back sparse module * bring back test_signal to pre-merge state * undo merge damage, part 2 of n * undo merge damage 2 of 2(?) * reinstate quick_start.md * copy from fix/1168-update-docker-image-and-documentation-on-release13x-and-main * corrected bug * docker scripts documentation * Fix tzdata handling and merging multiple actions The copy of tzdata was originally intended to be used from the root of the repository. The documentation states building docker images from the docker directory. This had to be aligned. Moreover, each RUN line in a Dockerfile represents the building of another intermediate image. This has to be taken into account when writing the files. Commands such as "cd" will not work on separate lines. * update pre-commit-config * Fix Pytorch release tracking workflows (#1264) * upgrade checkout action & use default token * increase tolerance for single-prec torch.inv comparison * fix typo --------- Co-authored-by: Claudia Comito <[email protected]> * Fix `ht.diff` for 1-element-axis edge case (#1201) * fix diff axis size one * fix diff() axis along split * remove debug code --------- Co-authored-by: Claudia Comito <[email protected]> * update version to 1.3.1 before release * revert * Update version before release (#1274) * update version to 1.3.1 before release * revert * update version before release * Update pytorch release PR workflow (#1286) * Update pytorch-latest-release.yml * Update latest-pytorch-support.yml * Delete .github/workflows/pytorch-latest-main.yml * Update checkout version --------- Co-authored-by: Claudia Comito <[email protected]> * Pin `setup-mpi` version to 1.2.0 in CI matrix (#1313) pinning setup-mpi action to version 1.2.0 --------- Co-authored-by: Michael Tarnawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * update version * skip ihfftn tests for older torch versions * add reason for skipping tests * fix test skipping heuristics * raise NotImplementedError for ihfftn with torch<1.11 * fix check for ihfftn * raise error re: ihfftn support on older torch versions * expand tests * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Gutiérrez Hermosillo Muriedas, Juan Pedro <[email protected]> Co-authored-by: Hoppe <[email protected]> Co-authored-by: Bjoern Hagemeier <[email protected]> Co-authored-by: Michael Tarnawa <[email protected]> Co-authored-by: Fabian Hoppe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
mainfor new features, latest release branch (e.g.release/1.3.x) for bug fixesDescription
Fixes and enhances the manually triggered workflows that create a new pull request on an PyTorch update. It uses the REF_NAME of the branch on which the workflow is triggered for the naming of the new branch and also puts it as the base branch for the PR creation.
Issue/s resolved: #1241
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no