Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setup-mpi version to 1.2.0 in CI matrix #1313

Merged
merged 69 commits into from
Dec 20, 2023

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Dec 19, 2023

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #1289

Changes proposed:

  • pinning setup-mpi action to version 1.2.0
  • TODO: find source of error for setup-mpi >= 1.2.1

Type of change

Bug fix (non-breaking change which TEMPORARILY fixes an issue)

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

1 similar comment
Copy link
Contributor

Thank you for the PR!

@mtar mtar added bug Something isn't working testing Implementation of tests, or test-related issues workflows CI continuous integration labels Dec 19, 2023
@mtar mtar linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05325e2) 92.17% compared to head (a30f9b4) 92.17%.
Report is 1 commits behind head on release/1.3.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.3.x    #1313   +/-   ##
==============================================
  Coverage          92.17%   92.17%           
==============================================
  Files                 75       75           
  Lines              10705    10705           
==============================================
  Hits                9867     9867           
  Misses               838      838           
Flag Coverage Δ
unit 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

mtar
mtar previously approved these changes Dec 20, 2023
Copy link
Collaborator

@mtar mtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore testing

@mtar mtar dismissed their stale review December 20, 2023 07:33

testing ignore

Copy link
Contributor

Thank you for the PR!

1 similar comment
Copy link
Contributor

Thank you for the PR!

Copy link
Collaborator

@mtar mtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 👍

Copy link
Contributor

Thank you for the PR!

@mtar mtar merged commit d19f024 into release/1.3.x Dec 20, 2023
42 checks passed
@mtar mtar deleted the bugs/1289-_Bug_CI_matrix_fails branch December 20, 2023 09:39
mtar added a commit that referenced this pull request Jan 3, 2024
* add back sparse module

* bring back test_signal to pre-merge state

* undo merge damage, part 2 of n

* undo merge damage 2 of 2(?)

* reinstate quick_start.md

* copy from fix/1168-update-docker-image-and-documentation-on-release13x-and-main

* corrected bug

* docker scripts documentation

* Fix tzdata handling and merging multiple actions

The copy of tzdata was originally intended to be used from the root
of the repository. The documentation states building docker images
from the docker directory. This had to be aligned.

Moreover, each RUN line in a Dockerfile represents the building of
another intermediate image. This has to be taken into account when
writing the files. Commands such as "cd" will not work on separate
lines.

* update pre-commit-config

* Fix Pytorch release tracking workflows (#1264)

* upgrade checkout action & use default token

* increase tolerance for single-prec torch.inv comparison

* fix typo

---------

Co-authored-by: Claudia Comito <[email protected]>

* Fix `ht.diff` for 1-element-axis edge case (#1201)

* fix diff axis size one

* fix diff() axis along split

* remove debug code

---------

Co-authored-by: Claudia Comito <[email protected]>

* update version to 1.3.1 before release

* revert

* Update version before release  (#1274)

* update version to 1.3.1 before release

* revert

* update version before release

* Update pytorch release PR workflow (#1286)

* Update pytorch-latest-release.yml

* Update latest-pytorch-support.yml

* Delete .github/workflows/pytorch-latest-main.yml

* Update checkout version

---------

Co-authored-by: Claudia Comito <[email protected]>

* Pin `setup-mpi` version to 1.2.0  in CI matrix  (#1313)

pinning setup-mpi action to version 1.2.0

---------

Co-authored-by: Michael Tarnawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update version

* skip ihfftn tests for older torch versions

* add reason for skipping tests

* fix test skipping heuristics

* raise NotImplementedError for ihfftn with torch<1.11

* fix check for ihfftn

* raise error re: ihfftn support on older torch versions

* expand tests

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Gutiérrez Hermosillo Muriedas, Juan Pedro <[email protected]>
Co-authored-by: Hoppe <[email protected]>
Co-authored-by: Bjoern Hagemeier <[email protected]>
Co-authored-by: Michael Tarnawa <[email protected]>
Co-authored-by: Fabian Hoppe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI continuous integration testing Implementation of tests, or test-related issues workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CI matrix fails with new setup-mpi 1.2.1
2 participants