Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of QR: stabilized Gram-Schmidt for split=1 and TS-QR for split=0 #1329

Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
f85a9f2
added file `myqr.py` that contains experiment in direction blockwise …
Oct 10, 2023
497b151
Update __init__.py
mrfh92 Oct 12, 2023
c8f3016
removed `myrandn` since `randn` is fixed meanwhile
Oct 13, 2023
134187f
...
Oct 16, 2023
9885afa
replaced previour QR implementation by the new one
Jan 22, 2024
c47f18c
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Jan 22, 2024
0b6f87e
...
Jan 22, 2024
eb84b53
refactoring
Jan 22, 2024
f2ae33d
...
Jan 26, 2024
7bf93e3
added some unit tests for the refactored qr with split=1
Jan 26, 2024
15d15b0
...
Jan 26, 2024
f6419d0
resolved some bugs related to calc_q, calc_r etc.
Jan 26, 2024
1b8d8eb
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Jan 26, 2024
85d7a36
removed option overwrite_a
Jan 31, 2024
cdf1603
extended comments in the code
Jan 31, 2024
919af4a
...
Feb 1, 2024
03877ae
Merge branch 'features/1237-Try_out_pure_stabilized_Gram-Schmidt_for_…
Feb 1, 2024
e93ebd0
removed strange option full_q (should be addressed somewhere else later)
Feb 1, 2024
56909fa
formatting of warning
Feb 1, 2024
72e4b20
adapted API of new qr to follow the one in numpy
Feb 1, 2024
6e8fda5
first version of split=0 (TS-QR), stil with bugs
Feb 1, 2024
2e42efa
fixed some bugs, some others are stil there...
Feb 2, 2024
b1e658c
fixed some bugs: a problem was, e.g., that torch's qr returns non-con…
Feb 2, 2024
fdf83e2
still errors but I dont find them...
Feb 2, 2024
8f06856
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Feb 5, 2024
d455a3c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2024
2d26970
found bugs in TS-QR, now we should have a running version
Feb 5, 2024
8badbc8
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Feb 5, 2024
7933812
removed skip from some svd_tests on AMD (they were introduced due to …
Feb 5, 2024
bbf9337
Merge branch 'features/1237-Try_out_pure_stabilized_Gram-Schmidt_for_…
Feb 5, 2024
5185a48
Update test_matrixgallery.py
mrfh92 Feb 5, 2024
d3ec327
Update linalg.py
mrfh92 Feb 5, 2024
aafb9e2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2024
78da329
Update linalg.py
mrfh92 Feb 6, 2024
de82c0b
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Feb 22, 2024
9ab6c1b
resolved first parts of the comments in the review
Feb 27, 2024
220638a
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Feb 27, 2024
e7f15d2
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Feb 28, 2024
c433dd8
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
ClaudiaComito Mar 1, 2024
719f805
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
ClaudiaComito Apr 11, 2024
93fbfec
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
mrfh92 Apr 12, 2024
d93659b
updated docs of refactored QR since no batches of matrices are supported
Apr 15, 2024
0864422
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
ClaudiaComito Apr 16, 2024
5e007d3
modified docs according to review
Apr 17, 2024
f816969
removed "from time import sleep", completed dead end sentence in docs
Apr 17, 2024
830dbea
Merge branch 'main' into features/1237-Try_out_pure_stabilized_Gram-S…
ClaudiaComito Apr 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions benchmarks/cb/linalg.py
Original file line number Diff line number Diff line change
@@ -16,14 +16,12 @@ def matmul_split_1(a, b):

@monitor()
def qr_split_0(a):
for t in range(2, 3):
qr = a.qr(tiles_per_proc=t)
qr = ht.linalg.qr(a)


@monitor()
def qr_split_1(a):
for t in range(1, 3):
qr = a.qr(tiles_per_proc=t)
qr = ht.linalg.qr(a)


@monitor()
@@ -53,12 +51,16 @@ def run_linalg_benchmarks():
matmul_split_1(a, b)
del a, b

n = int((4000000 // MPI.COMM_WORLD.size) ** 0.5)
m = MPI.COMM_WORLD.size * n
a_0 = ht.random.random((m, n), split=0)
qr_split_0(a_0)
del a_0

n = 2000
a_0 = ht.random.random((n, n), split=0)
a_1 = ht.random.random((n, n), split=1)
qr_split_0(a_0)
qr_split_1(a_1)
del a_0, a_1
del a_1

n = 50
A = ht.random.random((n, n), dtype=ht.float64, split=0)
Loading