Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyTorch 2.4.1 (#1655) #1687

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Oct 21, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Backport of PR #1655

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

* Support latest PyTorch release

* Update bug_report.yml

* Update ci.yaml

* Update setup.py

* Update basic_test.py

* skip failing test hip/rocm

---------

Co-authored-by: ClaudiaComito <[email protected]>
Co-authored-by: Michael Tarnawa <[email protected]>
Co-authored-by: Fabian Hoppe <[email protected]>
(cherry picked from commit 78d480a)
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (8fda09b) to head (571f2bd).
Report is 1 commits behind head on release/1.5.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.5.x    #1687   +/-   ##
==============================================
  Coverage          92.13%   92.13%           
==============================================
  Files                 83       83           
  Lines              12171    12171           
==============================================
  Hits               11214    11214           
  Misses               957      957           
Flag Coverage Δ
unit 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtar mtar requested review from JuanPedroGHM and mrfh92 October 21, 2024 11:57
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks @mtar 👍

@mtar mtar merged commit 7e15ad2 into release/1.5.x Oct 21, 2024
74 checks passed
@mtar mtar deleted the backport-1655-to-release/1.5.x branch October 21, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants