update axum to 0.8 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsiles
commented
Jan 2, 2025
|
@Tpt I'll wait a few more days to see if tonic does a release so we don't depend on master+rev |
vsiles
force-pushed
the
vsiles/push-vxsyorzzwowk
branch
from
8c5b747 to
c50e6c6
Compare
|
No need to couple the update with tonic, they did the work on their end. |
|
I need to double check the changes to build.rs. |
vsiles
force-pushed
the
vsiles/push-vxsyorzzwowk
branch
2 times, most recently
from
2a6cb92 to
4c72b44
Compare
vsiles
force-pushed
the
vsiles/push-vxsyorzzwowk
branch
from
4c72b44 to
9fef425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating axum
and tonicto their latest releases: see #22In this PR, I drop support for the previous version and move to the latest ones (tonic is
master, not released yet).Will require a new release.
Keeping support for both seems to be quite troublesome to correctly keep track / expose the set of packages, but doable.Happy to discuss
Main change is related to this breaking change on axum: