Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom branded favicons #275

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

frostyfan109
Copy link
Collaborator

No description provided.

@frostyfan109 frostyfan109 merged commit f0d90e9 into develop Sep 20, 2023
4 checks passed
@frostyfan109 frostyfan109 deleted the feature/favicon-branding branch September 20, 2023 15:44
Copy link
Contributor

@gaurav gaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this locally, but it is working correctly at https://groupe.apps.renci.org/, so it should be correct!

@frostyfan109
Copy link
Collaborator Author

I've tested locally, to make sure everything is working still. It's just that branding favicons won't work locally. This is because for development, we use the webpack dev server, so we do:

  • index.ejs -> index.html (no intermediate step)
    For production, webpack does:
  • index.ejs -> index_template.html
    Then the start_server script generates an env.json file, and also generates an index.html using index_template.html and your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants