bss: increase read limit for bfg conn to 2 MiB #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: refactor
github-actions
bot
added
area: bss
ClaytonNorthey92
approved these changes
Aug 2, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase the read limit in BSS for the BFG connection to 2 MiB (previously 512 KiB).
When there is a lot of active PoP Miners broadcasting transactions, the
pop-txs-for-l2-blockresponse from BFG becomes too large for BSS to read. This increases the read limit to temporarily avoid this problem.Related to: #193
Changes
protocol.ConnOptionswhich can be used to provide options when creating aprotocol.Conn.