bfgd: simpler finality calculations with new table #353
+528
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: bfg
* add table who's rows each represent the lowest published btc block that an l2_keystone is found in * on bfg startup, backfill existing l2_keystones' lowest btc block * use pop_basis database notifications to continue to index these l2_keyston <-> lowest btc block * update finality queries to use this * allowing insertion of l2_keystone abreviated fields, as we sometimes will pull these from the btc chain and they are abbreviated there * add tests
ClaytonNorthey92
force-pushed
the
clayton/finality-redo-2
branch
from
91bcc9d to
4f843a2
Compare
ClaytonNorthey92
requested review from
marcopeereboom,
jcvernaleo,
max-sanchez and
joshuasing
ClaytonNorthey92
commented
Jan 4, 2025
joshuasing
reviewed
Jan 4, 2025
Co-authored-by: Joshua Sing <[email protected]>
Co-authored-by: Joshua Sing <[email protected]>
joshuasing
reviewed
Jan 6, 2025
joshuasing
reviewed
Jan 7, 2025
|
Two remaining copyright header issues (I really need to fix the linter, sorry!) - otherwise looks good to me. |
joshuasing
changed the title
Co-authored-by: Joshua Sing <[email protected]>
Co-authored-by: Joshua Sing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
simpler finality calculations with new table
Changes
more context:
this pr adds a database table
l2_keystones_lowest_btc_block, which asl2_keystone_abrev_hashas a primary key. this represents, for each distinct l2 keystone, the published lowest btc block this l2 keystone was found in. this way, we no longer have to calculate this at query time.