tbc: fix bug in keystone database and bring back performance #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
added
type: enhancement
We can estimate pretty accurately which transactions need a compaction and which don't. The issue at hand is that very small transactions may not flush quickly enough leading to reading of stale data. This may need some additional tinkering but try this for the time being.
marcopeereboom
force-pushed
the
marco/cachestrategy
branch
from
0122900 to
7c7a09a
Compare
Not sure how this snuck into main.
We MUST delete the cache in the database function and NOT use continue to skip over records we don't like. This led to continues growth of the keystone cache and improper flushing. Tests aren't passing and need to be investigated.
marcopeereboom
changed the title
marcopeereboom
changed the title
joshuasing
changed the title
joshuasing
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a serious bug in the keystone indexer that kept growing the keystone database.
Changes
While here, kill the very expensive database flush that slowed us down drastically. Also dedup vast amounts of code in crawler.