bugfix in substituting value with default

henzeb · Jan 7, 2023 · df47c11 · df47c11
1 parent 2a151ab
commit df47c11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Laravel/Middleware/SubstituteEnums.php b/src/Laravel/Middleware/SubstituteEnums.php
@@ -66,7 +66,7 @@ private function getParameters(Route|null $route): array
             $route?->signatureParameters(['subClass' => UnitEnum::class])
         )->mapWithKeys(
             function (ReflectionParameter $parameter) {
-                $backedEnumClass = rtrim((string)$parameter->getType(), '?');
+                $backedEnumClass = ltrim((string)$parameter->getType(), '?');
 
                 if (enum_exists($backedEnumClass)) {
                     return [$parameter->getName() => new ReflectionEnum($backedEnumClass)];

diff --git a/tests/Unit/Laravel/Middleware/SubstituteEnumsTest.php b/tests/Unit/Laravel/Middleware/SubstituteEnumsTest.php
@@ -59,6 +59,7 @@ function (SimpleEnum $status) {
 
         $router->get('/optional/{status?}',
             function (SimpleEnum $status = null) {
+                return $status?->name;
             }
         );
 
@@ -83,7 +84,8 @@ public function testShouldBindBasicEnum()
 
     public function testShouldBindBasicEnumOptionally()
     {
-        $this->get('/optional/')->assertOk();
+       // $this->get('/optional/')->assertOk()->assertSee('');
+        $this->get('/optional/open')->assertOk()->assertSee('Open');
     }
 
     public function testShouldBindBasicEnumWithDefault()