feat: generate id field using uuid #191
Conversation
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 68.75% 68.75%
=======================================
Files 28 28
Lines 560 560
=======================================
Hits 385 385
Misses 175 175
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -54,7 +54,8 @@ module.exports = | |||
| '"nodemon": "^2.0.19"', | |||
| '"mocha": "^10.0.0"', | |||
| '"lodash.camelcase": "^4.3.0"', | |||
| '"sugar-env": "^1.5.14"' | |||
| '"sugar-env": "^1.5.14"', | |||
| '"uuid": "^9.0.0"' | |||
There was a problem hiding this comment.
Can we use the native uuid?
https://nodejs.org/api/crypto.html#cryptorandomuuidoptions
| const dependency = { <%- props.name.pascalCase %>Repository } | ||
|
|
||
| const create<%- props.name.pascalCase %> = injection => | ||
| usecase('Create <%- props.name.pascalCase %>', { | ||
| // Input/Request metadata and validation | ||
| // Input/Request metadata and validation |
There was a problem hiding this comment.
Let's try to avoid unnecessary merges (spaces, tabs, etc)
| <% if(!props.mongo){ %>ctx.<%- props.name.camelCase %>.id = Math.floor(Math.random() * 100000).toString()<% } %> | ||
|
|
||
| if (!ctx.<%- props.name.camelCase %>.isValid()) | ||
| ctx.<%- props.name.camelCase %>.id = uuid.v4() |
There was a problem hiding this comment.
it seems a mongo if was removed. is it working with mongo?
There was a problem hiding this comment.
Yes. Worked perfectly
|
Thanks @rodrigodosanjosoliveira for the contribution |
|
On the migrations you would need something like this: |
Fixes #158
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance