duplicate_definition for internal classes with throwing constructors #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parzysty
force-pushed
the
master
branch
2 times, most recently
from
50561e5
to
00fb8c8
Compare
gluecodium/src/test/resources/smoke/throwing_constructors/input/ThrowingConstructors.lime
Outdated
Show resolved
Hide resolved
parzysty
force-pushed
the
master
branch
3 times, most recently
from
7d6f79c
to
d0ceca8
Compare
sameermahant
previously approved these changes
Aug 23, 2023
|
@parzysty could you add this fix in the CHANGELOG file here - https://github.com/heremaps/gluecodium/blob/master/CHANGELOG.md?plain=1#L3 ? |
Added ffi prefix to name of functions handling error and return type retrival from throwing functions. This prevent duplicate_definition error if more than one class has those function inside one file, for example in case of multiple internall classes. Relates-To: heremaps#1547 Signed-off-by: Rafal Parzych <[email protected]>
parzysty
changed the base branch from
1547-duplicate_definition-for-internal-classes-with-throwing-constructors
to
master
parzysty
force-pushed
the
master
branch
2 times, most recently
from
40262cc
to
14f5bf1
Compare
sameermahant
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ffi prefix to name of functions handling error and return type retrival from throwing functions. This prevent duplicate_definition error if more than one class has those function inside one file, for example in case of multiple internal classes.
Relates-To: #1547