Ensure that conversions are defined for lambdas defined in struct #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few notes for reviewers can be found below.
|
Hsilgos
reviewed
Oct 23, 2024
| struct StructWithLambda { | ||
| lambda LambdaCallback = (String?) -> String? | ||
|
|
||
| static fun invoke_callback(callback: LambdaCallback?): String? |
There was a problem hiding this comment.
Was it necessary to make lambda (and its parameters) optional?
There was a problem hiding this comment.
I did not check it before pushing the change. I used the received reproducer.
It has just been checked and it seems, that even without any optional parameters the problem reproduces.
E.g.:
lambda InnerLambda = () -> Void
static fun invoke_callback(callback: InnerLambda)
pwrobeldev
force-pushed
the
pwrobeldev/missing-lambda-conversion-functions-in-swift
branch
2 times, most recently
from
d4f4b31
to
90c5060
Compare
Hsilgos
previously approved these changes
Oct 23, 2024
In the case of Swift language, when lambda was defined in a structure, then the code could not compile because of missing conversion functions. Interestingly, that was not the case for classes. After investigation it turned out, that the root cause is related to missing inclusion of SwiftLambdaConversion template in SwiftStructConversion. This change: - adds missing inclusion of lambda conversions in the mentioned template (SwiftStructConversion.mustache) - implements functional tests for Swift to check that the fix works as expected - implements functional tests for Dart and Android to also cover the tested case in these technologies - updates the reference files for smoke tests related to definition of nested fields in structs Signed-off-by: Patryk Wrobel <[email protected]>
pwrobeldev
force-pushed
the
pwrobeldev/missing-lambda-conversion-functions-in-swift
branch
from
90c5060
to
a615096
Compare
|
No functional changes since last patch-set -- only |
Hsilgos
approved these changes
Oct 24, 2024
pwrobeldev
deleted the
pwrobeldev/missing-lambda-conversion-functions-in-swift
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of Swift language, when lambda was defined in a structure, then the code could not compile because of missing conversion functions. Interestingly, that was not the case for classes.
After investigation it turned out, that the root cause is related to missing inclusion of SwiftLambdaConversion template in SwiftStructConversion.
This change: