Naive implementation of UpgradeProtocol #38
Conversation
| // ========================================================================== | ||
|
|
||
| public double readAttributeDouble(String name) throws DevFailed { |
| try { | ||
| TangoMessage<Double> message = new TangoMessage<>("read", this.get_name(), name, TangoConst.Tango_DEV_DOUBLE, 0D); | ||
|
|
||
| message = marshaller.unmarshal(transport.send(marshaller.marshal(message))); |
| @@ -2020,6 +2080,10 @@ private static void checkDuplication(String[] list, String orig) throws DevFaile | |||
| */ | |||
| //========================================================================== | |||
| protected void finalize() { | |||
There was a problem hiding this comment.
Finalize is deprecated in Java 9 and is discouraged even before. Should use AutoCloseable and implement close mrthod.
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * @author Igor Khokhriakov <[email protected]> |
|
|
||
| import com.google.common.collect.Collections2; | ||
| import com.google.common.collect.Iterables; | ||
| import com.google.common.collect.Lists; |
There was a problem hiding this comment.
I suggest remove Guava if possible. Using mix of Guava and Java 8 is confusing. Most Guava functions have analogues in Java 8.
|
|
||
| @Override | ||
| public TangoMessage unmarshal(InputStream stream) { | ||
| return gson.fromJson(new BufferedReader(new InputStreamReader(stream, StandardCharsets.UTF_8)), TangoMessage.class); |
There was a problem hiding this comment.
Potential bug here. If there are subsequent reads from the same stream, BufferedReader will read its buffer size and the next reader will start in the wrong place. If the stream is exhausted after read, it should be closed.
|
|
||
| @Override | ||
| public TangoMessage unmarshal(InputStream stream) { | ||
| BufferedReader br = new BufferedReader(new InputStreamReader(stream, StandardCharsets.UTF_8)); |
| public String device; | ||
| public String target; | ||
| public int dataType; | ||
| public T value; |
There was a problem hiding this comment.
No serialization strategy here. I really do not like using toString for something other than debug. There should be either additional decoder/encoder strategy or limits on T.
| } | ||
|
|
||
| @Override | ||
| public void connect(String endpoint) throws IOException { |
There was a problem hiding this comment.
Logging here? Also there probably should be a check about connecting, when connection already exists.
|
@altavir thanks a lot for your input! |
More to think about: