-
Notifications
You must be signed in to change notification settings - Fork 100
ci: add continuous benchmarking #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/ci.yml
Outdated
|
||
benchmark: | ||
name: Bench | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: ubuntu-latest | |
runs-on: [self-hosted] |
Ci is unfortunately still failing, despite hermit-os/hermit-rs#708 being merged and also used. |
559bee2
to
592e8c2
Compare
@jounathaen it's passing now and results look good |
The benchmarks take 27 minutes now, which is 10 mins longer than the tests. Can we change the benchmark setup, so that the CI duration is not dominated by the benchmarks anymore (parallelize it on two runners or reduce the benchmark size)? |
I think the benchmarks taking more time is fine, but I would suggest running the benchmark suite after merging and on PRs only on demand. |
But in that case, we wouldn't know if a PR affects performance before merging it. |
As @mkroening pointed out, we already have gh-pages installed for this repository (https://hermit-os.github.io/kernel/hermit/). We would need to find a way of publishing the results on a different URL. Martin suggested a separate repository for gh-pages, where this action pushes to. Maybe a combination of both gh-pages into subdirectories is also possible. |
This will execute the benchmarks in the hermit-rs repo according to the
bench.json
file. Results will be published to Github Pages.CI will fail until hermit-os/hermit-rs#708 gets merged.