Skip to content

ci: add continuous benchmarking #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CarlWachter
Copy link
Contributor

This will execute the benchmarks in the hermit-rs repo according to the bench.json file. Results will be published to Github Pages.

CI will fail until hermit-os/hermit-rs#708 gets merged.


benchmark:
name: Bench
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-latest
runs-on: [self-hosted]

@jounathaen
Copy link
Member

Ci is unfortunately still failing, despite hermit-os/hermit-rs#708 being merged and also used.

@CarlWachter CarlWachter force-pushed the feat/cb branch 3 times, most recently from 559bee2 to 592e8c2 Compare May 21, 2025 11:22
@CarlWachter
Copy link
Contributor Author

@jounathaen it's passing now and results look good

@jounathaen
Copy link
Member

The benchmarks take 27 minutes now, which is 10 mins longer than the tests. Can we change the benchmark setup, so that the CI duration is not dominated by the benchmarks anymore (parallelize it on two runners or reduce the benchmark size)?

@mkroening
Copy link
Member

I think the benchmarks taking more time is fine, but I would suggest running the benchmark suite after merging and on PRs only on demand.

@jounathaen
Copy link
Member

I think the benchmarks taking more time is fine, but I would suggest running the benchmark suite after merging and on PRs only on demand.

But in that case, we wouldn't know if a PR affects performance before merging it.

@jounathaen
Copy link
Member

As @mkroening pointed out, we already have gh-pages installed for this repository (https://hermit-os.github.io/kernel/hermit/). We would need to find a way of publishing the results on a different URL. Martin suggested a separate repository for gh-pages, where this action pushes to. Maybe a combination of both gh-pages into subdirectories is also possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants