3.10.1 Release (#167)

heroiclabs · Dec 12, 2023 · 220e123 · 220e123
1 parent 236c313
commit 220e123
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Packages/Nakama/CHANGELOG.md b/Packages/Nakama/CHANGELOG.md
@@ -5,6 +5,11 @@ The format is based on [keep a changelog](http://keepachangelog.com/) and this p
 
 ### [Unreleased]
 
+## [3.10.1] - 2023-12-12
+
+### Changed
+- Retry functionality restored for `UnityWebRequest.Result.ConnectionError`.
+
 ## [3.10.0] - 2023-11-21
 ### Changed
 - Updated to use the Nakama and Satori .NET 3.10.0 release.

diff --git a/Packages/Nakama/Runtime/UnityWebRequestAdapter.cs b/Packages/Nakama/Runtime/UnityWebRequestAdapter.cs
@@ -182,6 +182,8 @@ private static bool IsTransientException(Exception e)
             {
                 switch (apiException.StatusCode)
                 {
+                    case -1:  // No HTTP Status Code. This should correspond directly to `UnityWebRequest.Result.ConnectionError`. Note this will retry on potentially non-transient errors, e.g., wrong URL/scheme/port, wrong SSL certificate, LB misconfiguration. But
+                              // we think it's worth retrying despite these cases because there are real transient errors that occur due to temporary connection issues prior to the establishment of an HTTP connection (e.g., during TCP handshake, SSL negotation).
                     case 500: // Internal Server Error often (but not always) indicates a transient issue in Nakama, e.g., DB connectivity.
                     case 502: // LB returns this to client if server sends corrupt/invalid data to LB, which may be a transient issue.
                     case 503: // LB returns this to client if LB determines or is told that server is unable to handle forwarded from LB, which may be a transient issue.

diff --git a/Packages/Nakama/package.json b/Packages/Nakama/package.json
@@ -1,6 +1,6 @@
 {
     "name": "com.heroiclabs.nakama-unity",
-    "version": "3.10.0",
+    "version": "3.10.1",
     "unity": "2018.4",
     "displayName": "Nakama Unity",
     "description": "Unity3D client for Nakama server written in C#.",