Correctly remove rank cache entries on account delete. (#1272)

Ranks cache entries for leaderboards with no expiry are now correctly removed on account delete.
heroiclabs · Oct 7, 2024 · 6cbe036 · 6cbe036
1 parent 0c94f92
commit 6cbe036
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr
 
 ### Fixed
 - Ensure matchmaker stats behave correctly if matchmaker becomes fully empty and idle.
+- Correctly clear rank cache entries on account deletion.
 
 ## [3.23.0] - 2024-07-27
 ### Added

diff --git a/server/core_leaderboard.go b/server/core_leaderboard.go
@@ -636,7 +636,7 @@ func LeaderboardRecordsDeleteAll(ctx context.Context, logger *zap.Logger, leader
 		}
 
 		expiryUnix := expiryTime.Time.Unix()
-		if expiryUnix <= currentTime {
+		if expiryUnix != 0 && expiryUnix <= currentTime {
 			// Expired ranks are handled by the rank cache itself.
 			continue
 		}