-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): setup multiarch build for arm64 #1161
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. Do you have a way to update the build README for binary releases too? |
I haven't touched the binary workflow, so they should work as setup previously. I wanted to try and avoid any breaks with existing code or CI/CD. If you want me to clean everything up so that it works with this single Dockerfile, and update the readme for how to run it for any platform with |
Removed duplicate docker builds for both the main server and the pluginbuilder Updated the scripts to automatically pull the latest tag and info: VER="$(git tag -l --sort=-creatordate | head -n 1)"
DOCKER_VER=heroiclabs/nakama:${VER:1}
echo Building $DOCKER_VER
docker buildx build --platform linux/amd64,linux/arm64 \
--builder=container \
--build-arg repo=https://github.com/heroiclabs/nakama.git \
--build-arg commit="$(git rev-parse --short HEAD)" \
--build-arg version=$VER \
--tag $DOCKER_VER \
--push . Note the |
Anything else that needs to be done here @mofirouz ? |
hello , please have a look at my Github : https://github.com/tobyw121/nakama_docker_aarch64/tree/main I have created a docker for a Nakama on aarch64 here . |
According to issue #1160 #1138
I do not know what the CI environment is for building the docker images. But I have updated the Dockerfile to be able to accommodate multiarch builds. Note my environment is
arm64
so I have to set up the docker for amd64, the converse may be true for your build CI environment.As per the
multi_arch
script the docker buildx environment needs to be setup:I assume the CI is a linux environment in which case buildx needs to be installed: https://github.com/docker/buildx?tab=readme-ov-file#linux-packages