Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gopher-lua to v1.1.1 #1219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade gopher-lua to v1.1.1 #1219

wants to merge 1 commit into from

Conversation

sesposito
Copy link
Member

No description provided.

@sesposito sesposito requested review from syhpoon and zyro May 28, 2024 16:25
syhpoon
syhpoon reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@syhpoon syhpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, what's up with all this inlining business here?
Why are we doing compiler's job? 🤔

@syhpoon
Copy link
Contributor

syhpoon commented May 29, 2024

Never mind, I didn't realize we just pulling pieces of the third party dep as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syhpoon syhpoon syhpoon left review comments

@zyro zyro zyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sesposito @syhpoon @zyro