Skip to content

Commit

Permalink
Incorporate published release phase (#24)
Browse files Browse the repository at this point in the history
* Establish heroku/release-phase dependency as 1.0.0 version across buildpacks

* Ember app Integration test validates Release Build and Web process loading Static Artifacts; includes fix to read custom error files via file server at runtime instead of at build time.

* Bump to current heroku/nodejs version

* All buildpack versions at 1.0.0

* Workaround pack registry collision during integration test
  • Loading branch information
mars authored Oct 24, 2024
1 parent 907c64d commit 15ccf22
Show file tree
Hide file tree
Showing 26 changed files with 564 additions and 361 deletions.
111 changes: 62 additions & 49 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions builder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export CR_PAT=XXXXX
echo $CR_PAT | docker login ghcr.io -u mars --password-stdin

# push the specific version
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-0.1.1_linux-arm64
docker push ghcr.io/heroku/builder-test-public:frontend-web-builder-0.1.1_linux-arm64
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-1.0.0_linux-arm64
docker push ghcr.io/heroku/builder-test-public:frontend-web-builder-1.0.0_linux-arm64

# also push as "latest"
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-latest_linux-arm64
Expand Down
4 changes: 2 additions & 2 deletions builder/builder.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ mirrors = ["public.ecr.aws/heroku/heroku:24"]
[[order]]
[[order.group]]
id = "heroku/website-nodejs"
version = "0.1.1"
version = "1.0.0"

[[order]]
[[order.group]]
id = "heroku/website"
version = "0.1.1"
version = "1.0.0"
4 changes: 2 additions & 2 deletions buildpacks/static-web-server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition.workspace = true
workspace = true

[dependencies]
libcnb = "0.22.0"
libcnb = "=0.25.0"
commons_ruby = { git = "https://github.com/heroku/buildpacks-ruby", branch = "main", package = "commons" }
libherokubuildpack = { version = "=0.22.0", default-features = false, features = ["download", "fs", "log", "tar", "toml"] }
indoc = "2"
Expand All @@ -20,5 +20,5 @@ ureq = "2"
indexmap = "2"

[dev-dependencies]
libcnb-test = "=0.22.0"
libcnb-test = "=0.25.0"
test_support.workspace = true
3 changes: 0 additions & 3 deletions buildpacks/static-web-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ Any dependencies to run this build command should be installed by an earlier bui

*Default: (none)*

> [!IMPORTANT]
> Release Phase capabilities are not yet supported. See [RFC: `heroku/release-phase` CNB](https://salesforce.quip.com/qViZA7facMoT).
A build command to execute during Heroku Release Phase.

```toml
Expand Down
2 changes: 1 addition & 1 deletion buildpacks/static-web-server/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ api = "0.10"

[buildpack]
id = "heroku/static-web-server"
version = "0.1.1"
version = "1.0.0"
name = "Heroku Static Web Server"
description = "A component buildpack used by Heroku's front-end web buildpacks, such as 'heroku/website' and 'heroku/website-nodejs'."

Expand Down
Loading

0 comments on commit 15ccf22

Please sign in to comment.