Skip to content

Commit

Permalink
Fix Node.js versioning (#28)
Browse files Browse the repository at this point in the history
* Fix that missing version in package spec broke packaging and building after a newer version was released

* Doc how to update Node.js

* Update Node.js buildpack to 3.3.1
  • Loading branch information
mars authored Nov 8, 2024
1 parent 2456248 commit d9c2b7d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ Set the [Front-end Web builder](builder/README.md) in `project.toml`.
cargo test -- --include-ignored
```

### Updating Node.js

These buildpacks include the heroku/nodejs buildpack, packaged at a specific version. To update the Bode.js buildpack:

1. check the [Docker Hub listing](https://hub.docker.com/r/heroku/buildpack-nodejs/tags) for the latest version
1. update the version specified in the website-nodejs [buildpack](meta-buildpacks/website-nodejs/buildpack.toml) & [package](meta-buildpacks/website-nodejs/package.toml) specifications
1. ensure integration tests still pass, see [Run Tests](#run-tests)

### Releasing A New Version

[Action workflows](https://github.com/heroku/buildpacks-frontend-web/actions) are used to automate the release process:
Expand Down
2 changes: 1 addition & 1 deletion meta-buildpacks/website-nodejs/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ version = "1.0.1"

[[order.group]]
id = "heroku/nodejs"
version = "3.2.16"
version = "3.3.1"

[[order.group]]
id = "heroku/static-web-server"
Expand Down
2 changes: 1 addition & 1 deletion meta-buildpacks/website-nodejs/package.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ uri = "."
uri = "libcnb:heroku/website-ember"

[[dependencies]]
uri = "urn:cnb:registry:heroku/nodejs"
uri = "urn:cnb:registry:heroku/nodejs@3.3.1"

[[dependencies]]
uri = "libcnb:heroku/static-web-server"
Expand Down

0 comments on commit d9c2b7d

Please sign in to comment.