Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New heroku/release-phase dependency #20

Closed
wants to merge 1 commit into from
Closed

New heroku/release-phase dependency #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions builder/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,17 @@ Then, commit and `git push heroku` to a Fir app.

*Buildpack version numbers should be set in the follwoing commands, after running [Prepare Release workflow](../README.md#releasing-a-new-version).*

Generate an internal preview builder for these buildpacks:
To generate an internal preview builder for these buildpacks:

Start from a working directory that contains both repo directories `buildpacks-release-phase/` & `buildpacks-frontend-web/`, checked-out to the commit to package & release.

```bash
cd ../buildpacks-release-phase
cargo libcnb package --release --target aarch64-unknown-linux-musl
pack buildpack package release-phase --config packaged/aarch64-unknown-linux-musl/release/heroku_release-phase/package.toml --target "linux/arm64" --format file
mv release-phase.cnb ../buildpacks-frontend-web/

cd ../buildpacks-frontend-web
cargo libcnb package --release --target aarch64-unknown-linux-musl
pack buildpack package website --config packaged/aarch64-unknown-linux-musl/release/heroku_website/package.toml --target "linux/arm64" --format file
pack buildpack package website-nodejs --config packaged/aarch64-unknown-linux-musl/release/heroku_website-nodejs/package.toml --target "linux/arm64" --format file
Expand All @@ -39,9 +47,9 @@ Using https://github.com/heroku/builder-test-public
export CR_PAT=XXXXX
echo $CR_PAT | docker login ghcr.io -u mars --password-stdin

# push the specific version
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-0.1.1_linux-arm64
docker push ghcr.io/heroku/builder-test-public:frontend-web-builder-0.1.1_linux-arm64
# push the specific version (set this example to the correct new version)
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-0.2.0_linux-arm64
docker push ghcr.io/heroku/builder-test-public:frontend-web-builder-0.2.0_linux-arm64

# also push as "latest"
docker tag frontend-web-builder ghcr.io/heroku/builder-test-public:frontend-web-builder-latest_linux-arm64
Expand Down
8 changes: 6 additions & 2 deletions builder/builder.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ mirrors = ["public.ecr.aws/heroku/heroku:24"]
id = "heroku/website"
uri = "../website.cnb"

[[buildpacks]]
id = "heroku/release-phase"
uri = "../release-phase.cnb"

[[order]]
[[order.group]]
id = "heroku/website-nodejs"
version = "0.1.1"
version = "0.3.0"

[[order]]
[[order.group]]
id = "heroku/website"
version = "0.1.1"
version = "0.3.0"
8 changes: 6 additions & 2 deletions meta-buildpacks/website-nodejs/buildpack.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ api = "0.10"

[buildpack]
id = "heroku/website-nodejs"
version = "0.1.1"
version = "0.3.0"
name = "Heroku Website/Node.js"
description = "Heroku's buildpack for static web apps that require Node.js for build."
keywords = ["ember", "emberjs", "heroku"]
Expand All @@ -14,7 +14,11 @@ type = "MIT"

[[order.group]]
id = "heroku/nodejs"
version = "3.2.13"
version = "3.2.14"

[[order.group]]
id = "heroku/release-phase"
version = "0.2.0"

[[order.group]]
id = "heroku/static-web-server"
Expand Down
4 changes: 4 additions & 0 deletions meta-buildpacks/website-nodejs/package.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ uri = "."
[[dependencies]]
uri = "libcnb:heroku/website-ember"

[[dependencies]]
# Where does this come from? See /builder/README.md
uri = "../../release-phase.cnb"

[[dependencies]]
uri = "urn:cnb:registry:heroku/nodejs"

Expand Down
6 changes: 5 additions & 1 deletion meta-buildpacks/website/buildpack.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ api = "0.10"

[buildpack]
id = "heroku/website"
version = "0.1.1"
version = "0.3.0"
name = "Heroku Website"
description = "Heroku's buildpack for static websites."
keywords = ["website", "html", "javascript", "css", "static", "heroku"]
Expand All @@ -12,6 +12,10 @@ type = "MIT"

[[order]]

[[order.group]]
id = "heroku/release-phase"
version = "0.2.0"

[[order.group]]
id = "heroku/static-web-server"
version = "0.1.1"
Expand Down
4 changes: 4 additions & 0 deletions meta-buildpacks/website/package.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,9 @@ uri = "."
[[dependencies]]
uri = "libcnb:heroku/website-public-html"

[[dependencies]]
# Where does this come from? See /builder/README.md
uri = "../../release-phase.cnb"

[[dependencies]]
uri = "libcnb:heroku/static-web-server"
Loading