Fix issues with Docker Hub rate limits in CI #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the Node.js CNB repo, this repo is occasionally hitting Docker Hub rate limit errors on the ARM jobs in the matrix like so: https://github.com/heroku/buildpacks-go/actions/runs/9796334219/job/27051359595#step:8:10 These are due to the fact that the `pub-hk-ubuntu-22.04-arm-small` ARM runner also has a static IP enabled, which means all traffic from any runners in that group go through a single load balance with the fixed IP. This not only causes throughput/reliability issues, but means that we're more likely to hit the Docker Hub rate limit. As such, we requested the creation of some new runner groups that separate out the "need a fixed IP for writes" vs "need more compute or an ARM CPU" use-cases. As an added bonus these groups are also using Ubuntu 24.04. See: https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd This PR switches to those new groups, and also adds pre-pulling of the run image to prevent it being pulled multiple times when the tests run (`libcnb-test` uses `--pull-policy if-not-present` with `pack build`, but the tests run concurrently so on first run multiple pulls will otherwise be performed). See also: heroku/buildpacks-python#223 GUS-W-16238120.
edmorley
commented
Jul 15, 2024
This was referenced Jul 15, 2024
edmorley
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Jul 15, 2024
To update to Ubuntu 24.04, and to prevent the rate limit issues mentioned here: heroku/buildpacks-go#283 See also: https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md GUS-W-16238120.
joshwlewis
approved these changes
Jul 15, 2024
edmorley
added a commit
to heroku/buildpacks-ruby
that referenced
this pull request
Jul 16, 2024
To update to Ubuntu 24.04, and to prevent the rate limit issues mentioned here: heroku/buildpacks-go#283 I've not added the run image pre-pulling step used by some of the other CNB repos, since this repo doesn't currently use a matrix to test builder image versions, and instead varies the builder test by test, which (a) means I'd have to hardcode a list, (b) means that the benefit is less. See also: https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md GUS-W-16238120.
edmorley
added a commit
to heroku/buildpacks-php
that referenced
this pull request
Jul 16, 2024
Switches to the new GitHub Actions runner groups to: 1. Avoid the rate limit issues mentioned in: heroku/buildpacks-go#283 2. To update to Ubuntu 24.04 Also pre-pulls the builder and run images to prevent duplicate pulls and impact on rate limits, as mentioned in: heroku/buildpacks-python#223 See also: https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md GUS-W-16238120.
edmorley
added a commit
to heroku/buildpacks-jvm
that referenced
this pull request
Jul 17, 2024
Switches to the new GitHub Actions runner groups to: 1. Avoid the rate limit issues mentioned in: heroku/buildpacks-go#283 2. To update to Ubuntu 24.04 Also pre-pulls the builder and run images to prevent duplicate pulls and impact on rate limits, as mentioned in: heroku/buildpacks-python#223 See also: https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md GUS-W-16238120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the Node.js CNB repo, this repo is occasionally hitting Docker Hub rate limit errors on the ARM jobs in the matrix like so:
https://github.com/heroku/buildpacks-go/actions/runs/9796334219/job/27051359595#step:8:10
These are due to the fact that the
pub-hk-ubuntu-22.04-arm-smallARM runner also has a static IP enabled, which means all traffic from any runners in that group go through a single load balancer with the fixed IP. This not only causes throughput/reliability issues, but means that we're more likely to hit the Docker Hub rate limit.As such, we requested the creation of some new runner groups that separate out the "need a fixed IP for writes" vs "need more compute or an ARM CPU" use-cases. As an added bonus these groups are also using Ubuntu 24.04. See:
https://salesforce.quip.com/bu6UA0KImOxJ#temp:C:GZR57becb9df8d94f80b132168fd
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
This PR switches to those new groups, and also adds pre-pulling of the run image to prevent it being pulled multiple times when the tests run (
libcnb-testuses--pull-policy if-not-presentwithpack build, but the tests run concurrently so on first run multiple pulls will otherwise be performed). See also:heroku/buildpacks-python#223
GUS-W-16238120.