Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gradle buildpack #487

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Add Gradle buildpack #487

merged 7 commits into from
Sep 14, 2023

Conversation

Malax
Copy link
Member

@Malax Malax commented May 10, 2023 •
edited
Loading

Adds a MVP Gradle Buildpack to the repo and the heroku/java meta-buildpack. Things that are getting addressed at a later time, mostly to ensure all buildpacks in this repo employ the same strategy for similar tasks:

  • More thorough integration tests, in tandem with a unified testing strategy between all build tool CNBs in this repository: heroku/maven, heroku/gradle, heroku/sbt and heroku/leiningen (upcoming).
  • Unified handling of buildpack configuration between all buildpacks in this repo.
  • Improved documentation, also in a unified manner for all buildpacks in this repository.

It otherwise matches the features found in the existing Heroku Gradle buildpack (and more).

Ref: GUS-W-11739495

@Malax Malax force-pushed the malax/heroku/gradle branch 2 times, most recently from c632c89 to 254fcb9 Compare May 15, 2023 13:35
@Malax Malax force-pushed the malax/heroku/gradle branch 3 times, most recently from b1e8d6f to 8792c14 Compare June 28, 2023 08:20
@Malax Malax force-pushed the malax/heroku/gradle branch 2 times, most recently from 9b2866a to feab6c2 Compare August 18, 2023 15:54
@Malax Malax force-pushed the malax/heroku/gradle branch 7 times, most recently from b9499ad to 5257b9f Compare August 31, 2023 12:04
@Malax Malax force-pushed the malax/heroku/gradle branch 4 times, most recently from af4d783 to a13897a Compare September 12, 2023 13:09
@Malax Malax force-pushed the malax/heroku/gradle branch from a13897a to 763560e Compare September 12, 2023 13:13
@Malax Malax marked this pull request as ready for review September 12, 2023 13:20
@Malax Malax requested a review from a team as a code owner September 12, 2023 13:20
colincasey
colincasey reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@colincasey colincasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice!

edmorley
edmorley approved these changes Sep 13, 2023
View reviewed changes
buildpacks/gradle/CHANGELOG.md Show resolved Hide resolved
buildpacks/gradle/Cargo.toml Outdated Show resolved Hide resolved
buildpacks/gradle/src/errors.rs Outdated Show resolved Hide resolved
buildpacks/gradle/src/errors.rs Show resolved Hide resolved
buildpacks/gradle/src/errors.rs Show resolved Hide resolved
shared/src/fs.rs Outdated Show resolved Hide resolved
@Malax Malax enabled auto-merge (squash) September 14, 2023 10:36
@Malax Malax merged commit 4e2a4f7 into main Sep 14, 2023
@Malax Malax deleted the malax/heroku/gradle branch September 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

@colincasey colincasey colincasey left review comments

Assignees
No one assigned
Labels
buildpack: heroku/gradle buildpack: heroku/java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Malax @colincasey @edmorley