Skip default process registration when Procfile is present #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change treats the presence of a `Procfile` as the "source of truth" for how processes should be registered and will skip the default process registration that was previously performed for `npm`, `yarn`, and `pnpm`. Fixes #908 Related to heroku/buildpacks-go#319
joshwlewis
approved these changes
Dec 12, 2024
heroku-linguist bot
added a commit
that referenced
this pull request
Dec 13, 2024
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.0`. - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-install` to `3.4.0`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.0`. - Updated `heroku/nodejs-pnpm-install` to `3.4.0`. - Updated `heroku/nodejs-yarn` to `3.4.0`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-function-invoker` to `3.4.0`. - Updated `heroku/nodejs-npm` to `3.4.0`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](#985)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](#985)) ## heroku/nodejs-yarn ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](#985))
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 13, 2024
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.0`. - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-install` to `3.4.0`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.0`. - Updated `heroku/nodejs-pnpm-install` to `3.4.0`. - Updated `heroku/nodejs-yarn` to `3.4.0`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-function-invoker` to `3.4.0`. - Updated `heroku/nodejs-npm` to `3.4.0`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985)) ## heroku/nodejs-yarn ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985))
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 13, 2024
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.0`. - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-engine` to `3.4.0`. - Updated `heroku/nodejs-npm-install` to `3.4.0`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.0`. - Updated `heroku/nodejs-pnpm-install` to `3.4.0`. - Updated `heroku/nodejs-yarn` to `3.4.0`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.0`. - Updated `heroku/nodejs-function-invoker` to `3.4.0`. - Updated `heroku/nodejs-npm` to `3.4.0`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985)) ## heroku/nodejs-yarn ### Changed - Default processes will no longer be registered if a Procfile is present. ([#985](heroku/buildpacks-nodejs#985)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change treats the presence of a
Procfileas the "source of truth" for how processes should be registered and will skip the default process registration that was previously performed fornpm,yarn, andpnpm.Fixes #908
Related to heroku/buildpacks-go#319