Use the Procfile CNB from the builder in tests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Procfile CNB has just moved Docker Hub repo. Instead of just updating the repo URL used in the tests, I've switched the tests to use the Procfile CNB from the builder image instead. This is now safe to do, since there is now only ever one Procfile version in the builder after: heroku/buildpacks-jvm#608 heroku/buildpacks-nodejs#696 Using the Procfile version from the builder has a few advantages: - Greater parity with what will be used in production - Less churn from us needing to bump the versions here - Faster, since saves having to pull a new image from Docker Hub There is the chance of breakage, should the upstream Procfile CNB make a breaking change, however, that should be very rare and will only affect tests, so it seems worth the tradeoff. GUS-W-14356096.
runesoerensen
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Procfile CNB has just moved Docker Hub repo:
heroku/buildpacks-procfile#219
Instead of updating the repo URL used in the tests, I've switched the tests to use the Procfile CNB from the builder image instead.
This is now safe to do, since there is now only ever one Procfile version in the builder after:
heroku/buildpacks-jvm#608
heroku/buildpacks-nodejs#696
Using the Procfile version from the builder has a few advantages:
There is the chance of breakage, should the upstream Procfile CNB make a breaking change, however, that should be very rare and will only affect tests, and seeing that breakage here is actually kinda the point :-)
GUS-W-14356096.