Expand buildpack detection known file list #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more Python project related file and directory names to the list recognised by buildpack detection. Such apps will still fail to build successfully (since they are missing a package manager file), but will now be shown a more helpful error message during compile, rather than the generic: "No default language could be detected for this app" The list is based on builds logs analysis of builds that filed to pass detection, plus builds that passed detection but didn't have a valid package manager file. (Possible since the build logs error message includes a file listing of the root directory of the app.) GUS-W-17530142.
runesoerensen
approved these changes
Jan 5, 2025
heroku-linguist bot
added a commit
that referenced
this pull request
Jan 8, 2025
## heroku/python ### Removed - Removed support for Python 3.8. ([#313](#313)) ### Changed - Deprecated support for Python 3.9. ([#314](#314)) - Buildpack detection now recognises more Python-related file and directory names. ([#312](#312)) - Improved the error messages shown for EOL or unrecognised major Python versions. ([#313](#313))
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jan 8, 2025
## heroku/python ### Removed - Removed support for Python 3.8. ([#313](heroku/buildpacks-python#313)) ### Changed - Deprecated support for Python 3.9. ([#314](heroku/buildpacks-python#314)) - Buildpack detection now recognises more Python-related file and directory names. ([#312](heroku/buildpacks-python#312)) - Improved the error messages shown for EOL or unrecognised major Python versions. ([#313](heroku/buildpacks-python#313))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more Python project related file and directory names to the list recognised by buildpack detection. Such apps will still fail to build successfully (since they are missing a package manager file), but will now be shown a more helpful error message during compile, rather than the generic:
"No default language could be detected for this app"
The list is based on builds logs analysis of builds that filed to pass detection, plus builds that passed detection but didn't have a valid package manager file. (Possible since the build logs error message includes a file listing of the root directory of the app.)
This is the CNB equivalent of heroku/heroku-buildpack-python#1729.
GUS-W-17530142.