Change to mutable layers

The layer trait interface was changed to mutable in heroku/libcnb.rs#669
heroku · May 10, 2024 · 38b0b81 · 38b0b81
1 parent d5b002c
commit 38b0b81
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 14 deletions.
diff --git a/buildpacks/ruby/src/layers/bundle_download_layer.rs b/buildpacks/ruby/src/layers/bundle_download_layer.rs
@@ -46,7 +46,7 @@ impl<'a> Layer for BundleDownloadLayer<'a> {
     }
 
     fn create(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_path: &Path,
     ) -> Result<LayerResult<Self::Metadata>, RubyBuildpackError> {
@@ -106,7 +106,7 @@ impl<'a> Layer for BundleDownloadLayer<'a> {
     }
 
     fn existing_layer_strategy(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_data: &LayerData<Self::Metadata>,
     ) -> Result<ExistingLayerStrategy, RubyBuildpackError> {

diff --git a/buildpacks/ruby/src/layers/bundle_install_layer.rs b/buildpacks/ruby/src/layers/bundle_install_layer.rs
@@ -114,9 +114,10 @@ impl Layer for BundleInstallLayer<'_> {
             cache: true,
         }
     }
+
     /// Runs with gems cache from last execution
     fn update(
-        &self,
+        &mut self,
         context: &BuildContext<Self::Buildpack>,
         layer_data: &LayerData<Self::Metadata>,
     ) -> Result<LayerResult<Self::Metadata>, RubyBuildpackError> {
@@ -150,7 +151,7 @@ impl Layer for BundleInstallLayer<'_> {
 
     /// Runs when with empty cache
     fn create(
-        &self,
+        &mut self,
         context: &BuildContext<Self::Buildpack>,
         layer_path: &Path,
     ) -> Result<LayerResult<Self::Metadata>, RubyBuildpackError> {
@@ -172,7 +173,7 @@ impl Layer for BundleInstallLayer<'_> {
     /// if a coder updates env vars they won't be set unless update or
     /// create is run.
     fn existing_layer_strategy(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_data: &LayerData<Self::Metadata>,
     ) -> Result<ExistingLayerStrategy, RubyBuildpackError> {

diff --git a/buildpacks/ruby/src/layers/metrics_agent_install.rs b/buildpacks/ruby/src/layers/metrics_agent_install.rs
@@ -77,7 +77,7 @@ impl<'a> Layer for MetricsAgentInstall<'a> {
     }
 
     fn create(
-        &self,
+        &mut self,
         _context: &libcnb::build::BuildContext<Self::Buildpack>,
         layer_path: &std::path::Path,
     ) -> Result<
@@ -102,7 +102,7 @@ impl<'a> Layer for MetricsAgentInstall<'a> {
     }
 
     fn update(
-        &self,
+        &mut self,
         _context: &libcnb::build::BuildContext<Self::Buildpack>,
         layer_data: &libcnb::layer::LayerData<Self::Metadata>,
     ) -> Result<
@@ -123,7 +123,7 @@ impl<'a> Layer for MetricsAgentInstall<'a> {
     }
 
     fn existing_layer_strategy(
-        &self,
+        &mut self,
         _context: &libcnb::build::BuildContext<Self::Buildpack>,
         layer_data: &libcnb::layer::LayerData<Self::Metadata>,
     ) -> Result<libcnb::layer::ExistingLayerStrategy, <Self::Buildpack as libcnb::Buildpack>::Error>
@@ -144,7 +144,7 @@ impl<'a> Layer for MetricsAgentInstall<'a> {
     }
 
     fn migrate_incompatible_metadata(
-        &self,
+        &mut self,
         _context: &libcnb::build::BuildContext<Self::Buildpack>,
         _metadata: &GenericMetadata,
     ) -> Result<

diff --git a/buildpacks/ruby/src/layers/ruby_install_layer.rs b/buildpacks/ruby/src/layers/ruby_install_layer.rs
@@ -54,7 +54,7 @@ impl<'a> Layer for RubyInstallLayer<'a> {
     }
 
     fn create(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_path: &Path,
     ) -> Result<LayerResult<Self::Metadata>, RubyBuildpackError> {
@@ -76,7 +76,7 @@ impl<'a> Layer for RubyInstallLayer<'a> {
     }
 
     fn existing_layer_strategy(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_data: &LayerData<Self::Metadata>,
     ) -> Result<ExistingLayerStrategy, RubyBuildpackError> {

diff --git a/commons/src/cache/in_app_dir_cache_layer.rs b/commons/src/cache/in_app_dir_cache_layer.rs
@@ -57,7 +57,7 @@ where
     }
 
     fn create(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         _layer_path: &Path,
     ) -> Result<LayerResult<Self::Metadata>, B::Error> {
@@ -68,7 +68,7 @@ where
     }
 
     fn existing_layer_strategy(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         layer_data: &LayerData<Self::Metadata>,
     ) -> Result<ExistingLayerStrategy, B::Error> {

diff --git a/commons/src/layer/configure_env_layer.rs b/commons/src/layer/configure_env_layer.rs
@@ -115,7 +115,7 @@ where
     }
 
     fn create(
-        &self,
+        &mut self,
         _context: &BuildContext<Self::Buildpack>,
         _layer_path: &Path,
     ) -> Result<LayerResult<Self::Metadata>, B::Error> {