Log when barnes is installed, or isn't

This presents a tip to the user to tell them how to enable metrics collection.
heroku · Sep 11, 2023 · 8e40054 · 8e40054
1 parent b5540ad
commit 8e40054
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/buildpacks/ruby/src/layers/metrics_agent_install.rs b/buildpacks/ruby/src/layers/metrics_agent_install.rs
@@ -197,7 +197,7 @@ fn write_execd_script(
 }
 
 fn install_agentmon(dir: &Path) -> Result<PathBuf, MetricsAgentInstallError> {
-    let agentmon = download_untar(DOWNLOAD_URL, &dir).map(|_| dir.join("agentmon"))?;
+    let agentmon = download_untar(DOWNLOAD_URL, dir).map(|_| dir.join("agentmon"))?;
 
     chmod_plus_x(&agentmon).map_err(MetricsAgentInstallError::PermissionError)?;
     Ok(agentmon)

diff --git a/buildpacks/ruby/src/main.rs b/buildpacks/ruby/src/main.rs
@@ -81,13 +81,18 @@ impl Buildpack for RubyBuildpack {
         let ruby_version = gemfile_lock.resolve_ruby("3.1.3");
 
         // ## Install metrics agent
+        let section = build_output::section("Metrics agent");
         if lockfile_contents.contains("barnes") {
-            let section = build_output::section("Metrics agent");
             context.handle_layer(
                 layer_name!("metrics_agent"),
                 MetricsAgentInstall { section },
             )?;
-        }
+        } else {
+            section.say_with_details(
+                "Skipping install",
+                "`gem 'barnes'` not found in Gemfile.lock",
+            );
+        };
 
         // ## Install executable ruby version