Configure process to complain about unset variable #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilacstella
force-pushed
the
lilacstella/hint-missing-param
branch
from
4e6ee55 to
a2a5646
Compare
lilacstella
changed the title
schneems
reviewed
Jul 30, 2024
…ildpacks-ruby into lilacstella/hint-missing-param
Co-authored-by: Richard Schneeman <[email protected]>
heroku-linguist bot
added a commit
that referenced
this pull request
Nov 27, 2024
## heroku/ruby ### Changed - Default process types defined by the Ruby buildpack now use IPv6 host `::` which is equivalent of IPv4 host `0.0.0.0`. This will only affect applications that do not define a `web` process type via the `Procfile` and [Procfile Cloud Native Buildpack](https://github.com/heroku/buildpacks-procfile). Those applications must make sure to update their configuration to bind to an IPv6 host. ([#354](#354)) ### Added - The buildpack now warns the user when environmental variables used in running the default process are not defined. ([#307](#307))
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Nov 27, 2024
## heroku/ruby ### Changed - Default process types defined by the Ruby buildpack now use IPv6 host `::` which is equivalent of IPv4 host `0.0.0.0`. This will only affect applications that do not define a `web` process type via the `Procfile` and [Procfile Cloud Native Buildpack](https://github.com/heroku/buildpacks-procfile). Those applications must make sure to update their configuration to bind to an IPv6 host. ([#354](#354)) ### Added - The buildpack now warns the user when environmental variables used in running the default process are not defined. ([#307](#307)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Nov 27, 2024
## heroku/ruby ### Changed - Default process types defined by the Ruby buildpack now use IPv6 host `::` which is equivalent of IPv4 host `0.0.0.0`. This will only affect applications that do not define a `web` process type via the `Procfile` and [Procfile Cloud Native Buildpack](https://github.com/heroku/buildpacks-procfile). Those applications must make sure to update their configuration to bind to an IPv6 host. ([#354](heroku/buildpacks-ruby#354)) ### Added - The buildpack now warns the user when environmental variables used in running the default process are not defined. ([#307](heroku/buildpacks-ruby#307))
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 9, 2024
## heroku/ruby ### Changed - Default process types defined by the Ruby buildpack now use IPv6 host `::` which is equivalent of IPv4 host `0.0.0.0`. This will only affect applications that do not define a `web` process type via the `Procfile` and [Procfile Cloud Native Buildpack](https://github.com/heroku/buildpacks-procfile). Those applications must make sure to update their configuration to bind to an IPv6 host. ([#354](heroku/buildpacks-ruby#354)) ### Added - The buildpack now warns the user when environmental variables used in running the default process are not defined. ([#307](heroku/buildpacks-ruby#307)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
docker run, the default rails app configuration assumes the existence of a$PORTenvironmental variable but does not tell the user that it is required. By making the lack of a definition for the environmental variable, the user can understand how to run the application properly.Resolves #306