[Stacked] Fixes CI linting #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/fix-clippy-stacked
branch
4 times, most recently
from
a0f781b to
566133e
Compare
schneems
force-pushed
the
schneems/fix-clippy-stacked
branch
from
566133e to
e80cdac
Compare
runesoerensen
approved these changes
Sep 23, 2024
schneems
merged commit a0bd563
into
schneems/continue-migrate-metrics-agent-layer
7 of 8 checks passed
schneems
added a commit
that referenced
this pull request
Sep 23, 2024
* Use metadata as single point of truth (SPOT) Previously we were using a metadata structure that was decoupled from the work being done (stored in the DOWNLOAD_URL constant). This created the possibility to update one without the other. * Style URLs * [Stacked] Fixes CI linting (#323) * Clippy recommended method * Allow deprecated Layer use * Clippy lint suggestions * Allow deprecated layer API usage * Allow deprecated layer API * Fewer allow(deprecation)-s
runesoerensen
added a commit
that referenced
this pull request
Sep 23, 2024
* Use libcnb 0.23.0 * Migrate metrics_agent layer to struct layer API * Improve metrics agent logging Also update integration test to verify build output * Require download_url value * Remove unnecessary layer env logic As noted in the removed comment: It doesn't seem necessary as the layer env isn't explicitly modified as far as I can tell -- but perhaps there was some trait API magic happening I'm not familiar with? * Migrate metrics_agent log output to bullet_stream * [Stacked] Continue metadata migration (#322) * Use metadata as single point of truth (SPOT) Previously we were using a metadata structure that was decoupled from the work being done (stored in the DOWNLOAD_URL constant). This created the possibility to update one without the other. * Style URLs * [Stacked] Fixes CI linting (#323) * Clippy recommended method * Allow deprecated Layer use * Clippy lint suggestions * Allow deprecated layer API usage * Allow deprecated layer API * Fewer allow(deprecation)-s --------- Co-authored-by: Richard Schneeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly allows using the deprecated API while we transition to the new API. This would allow us to merge #321 as a smaller PR and then we can gradually transition the rest of the codebase instead of one large shebang re-write.