Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schneems/refactor bundle install layer #331

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Oct 4, 2024

No description provided.

The `with_data` input is required due to type inference compilation requirements. If someone doesn't care they can call it with `|_,_|, ()` and it's explicit that they're not relying on the prior cache state. The alternative would be returning the old metadata always and then allowing the receiver to do something with it. You can still do that via `|old, _| old.clone()` as seen here, but it doesn't add a `Clone` requirement to the metadata.
Removed calls to cached_layer_write_metadata in the tests and instead added a comment that informs the reader the relationship between the test and the cache.
@schneems schneems changed the base branch from main to schneems/refactor-bundler October 4, 2024 01:17
@schneems
Copy link
Contributor Author

schneems commented Oct 4, 2024

I think i'm going to do this one again. I ended up effectively trying a few ideas and then going back to an earlier/easier one regarding how to get data out of the layer.

@schneems
Copy link
Contributor Author

schneems commented Oct 4, 2024

Replaced by #332

@schneems schneems closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant