-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schneems/refactor bundle install layer #331
Closed
schneems
wants to merge
22
commits into
schneems/refactor-bundler
from
schneems/refactor-bundle-install-layer
Closed
Schneems/refactor bundle install layer #331
schneems
wants to merge
22
commits into
schneems/refactor-bundler
from
schneems/refactor-bundle-install-layer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `with_data` input is required due to type inference compilation requirements. If someone doesn't care they can call it with `|_,_|, ()` and it's explicit that they're not relying on the prior cache state. The alternative would be returning the old metadata always and then allowing the receiver to do something with it. You can still do that via `|old, _| old.clone()` as seen here, but it doesn't add a `Clone` requirement to the metadata.
Removed calls to cached_layer_write_metadata in the tests and instead added a comment that informs the reader the relationship between the test and the cache.
I think i'm going to do this one again. I ended up effectively trying a few ideas and then going back to an earlier/easier one regarding how to get data out of the layer. |
Replaced by #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.