Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated interfaces #385

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions commons/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog for commons features

## 2024-01-14

### Changed

- Remove deprecated interfaces: `layer::ConfigureEnvLayer` and `layer::DefaultEnvLayer` and the `output` module (https://github.com/heroku/buildpacks-ruby/pull/385)

## 2024-01-13

### Added
Expand Down
7 changes: 0 additions & 7 deletions commons/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@ workspace = true

[dependencies]
byte-unit = "5"
const_format = "0.2"
# TODO: Consolidate on either the regex crate or the fancy-regex crate, since this repo currently uses both.
fancy-regex = "0.14"
fs_extra = "1"
fs-err = "3"
glob = "0.3"
indoc = "2"
lazy_static = "1"
# libcnb has a much bigger impact on buildpack behaviour than any other dependencies,
# so it's pinned to an exact version to isolate it from lockfile refreshes.
libcnb = "=0.26.1"
libherokubuildpack = { version = "=0.26.1", default-features = false, features = ["command"] }
regex = "1"
serde = "1"
sha2 = "0.10"
Expand All @@ -33,8 +29,5 @@ cache_diff = "1.0"

[dev-dependencies]
filetime = "0.2"
indoc = "2"
libcnb-test = "=0.26.1"
pretty_assertions = "1"
toml = "0.8"
bullet_stream = "0.3.0"
8 changes: 0 additions & 8 deletions commons/src/layer.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
mod configure_env_layer;
mod default_env_layer;
pub mod diff_migrate;

#[deprecated(note = "Use the struct layer API in the latest libcnb.rs instead")]
pub use self::configure_env_layer::ConfigureEnvLayer;

#[deprecated(note = "Use the struct layer API in the latest libcnb.rs instead")]
pub use self::default_env_layer::DefaultEnvLayer;
128 changes: 0 additions & 128 deletions commons/src/layer/configure_env_layer.rs

This file was deleted.

87 changes: 0 additions & 87 deletions commons/src/layer/default_env_layer.rs

This file was deleted.

1 change: 0 additions & 1 deletion commons/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ pub mod gem_version;
pub mod gemfile_lock;
pub mod layer;
pub mod metadata_digest;
pub mod output;
Loading