Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials #71

Closed
wants to merge 1 commit into from
Closed

Update tutorials #71

wants to merge 1 commit into from

Conversation

heroku-linguist[bot]
Copy link
Contributor

@heroku-linguist heroku-linguist bot requested a review from a team as a code owner December 17, 2024 21:00
@heroku-linguist heroku-linguist bot enabled auto-merge (squash) December 17, 2024 21:01
@schneems
Copy link
Contributor

Hmmm...we can maybe skip running GHA for updates from GHA

@schneems schneems closed this Dec 17, 2024
auto-merge was automatically disabled December 17, 2024 21:03

Pull request was closed

schneems added a commit that referenced this pull request Dec 17, 2024
The PRs generated by the GHA have some 400,000+ lines changed in them #71. That is because it 2,000+ files installed including all the gems installed and Ruby. This is definitively not what we want. This behavior is documented in https://github.com/ruby/setup-ruby/tree/v1/?tab=readme-ov-file#bundle-config that it will place the files in `vendor/bundle`. To exclude the directory, we can add it to our `.gitignore`.
schneems added a commit that referenced this pull request Dec 18, 2024
* Only run CI when `docs/src` changed

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

* Include language in PR title

* Ignore GHA generated Ruby files

The PRs generated by the GHA have some 400,000+ lines changed in them #71. That is because it 2,000+ files installed including all the gems installed and Ruby. This is definitively not what we want. This behavior is documented in https://github.com/ruby/setup-ruby/tree/v1/?tab=readme-ov-file#bundle-config that it will place the files in `vendor/bundle`. To exclude the directory, we can add it to our `.gitignore`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant