Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also export UV_USE_IO_URING for later buildpacks #1351

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Also export UV_USE_IO_URING for later buildpacks #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7603e00
Also export uring settings to prevent timeouts in later buildpacks
joshwlewis Nov 21, 2024
b413050
Update changelog with release
joshwlewis Nov 21, 2024
ee5d820
Add IO_URING / AL2023 comments
joshwlewis Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [Unreleased]

## [v272] - 2024-11-21
colincasey marked this conversation as resolved.
Show resolved Hide resolved

- Export `UV_USE_IO_URING=0` for later buildpacks to prevent timeouts. ([#1351](https://github.com/heroku/heroku-buildpack-nodejs/pull/1351))

## [v271] - 2024-11-20

Expand Down Expand Up @@ -952,7 +955,8 @@ Accepts `cacheDirectories` array in package.json to override default `node_modul

- Documented at https://devcenter.heroku.com/articles/nodejs-support#cache-behavior

[unreleased]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v271...main
[unreleased]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v272...main
[v272]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v271...v272
[v271]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v270...v271
[v270]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v269...v270
[v269]: https://github.com/heroku/heroku-buildpack-nodejs/compare/v268...v269
Expand Down
11 changes: 11 additions & 0 deletions lib/environment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,16 @@ write_export() {
echo "export NODE_HOME=\"$build_dir/.heroku/node\"" >> "$bp_dir/export"
# shellcheck disable=SC2016
echo 'export NODE_OPTIONS=${NODE_OPTIONS:-"--max_old_space_size=2560"}' >> "$bp_dir/export"

# 2024-11-21:
# Set UV_USE_IO_URING for later buildpacks to prevent build timeouts when
# running `yarn install` on some Amazon Linux 2023 releases. This may be
# removed in the future when a fixed AL2023 release is available
# (~2024-12-09 or later).
#
# See https://github.com/npm/cli/issues/7814#issuecomment-2488626736
# → https://github.com/amazonlinux/amazon-linux-2023/issues/840#issuecomment-2485782075
# → https://lore.kernel.org/io-uring/[email protected]/T/#m57570b5f8f2fc00d5a17cfe18ffeeba9fc23a43d
echo 'export UV_USE_IO_URING=${UV_USE_IO_URING:-0}' >> "$bp_dir/export"
fi
}