Add Python binary build support for Heroku-24 #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for building Python binaries for Heroku-24 using GitHub Actions. Since the Heroku-24 base image supports both `amd64` and `arm64` (to allow for multi-arch CNBs), for Heroku-24 (only) we now also build binaries for both architectures. A later PR will add support for Heroku-24 to the buildpack itself, however, that depends on (a) the Python binaries already having been built, (b) the Heroku build system for Heroku-24 being ready, so those changes are not being made here. GUS-W-15571102.
edmorley
force-pushed
the
heroku-24-binaries
branch
from
d48e8c4 to
d4b40b2
Compare
|
Builds generated using: for v in 3.12.{0..3}; do
gh workflow run build_python_runtime.yml -F "python_version=${v}" -F "stack=heroku-24"
done(I'll re-run these once Ubuntu 24.04 is GA and the base images refreshed with the final libs versions) |
edmorley
added a commit
that referenced
this pull request
Apr 26, 2024
Following on from #1574 (which added support for building and releasing Python binaries for Heroku-24), this adds support for the new stack to the buildpack itself. Heroku-24's base images are published as both `amd64` and `arm64` variants (primarily for CNB multi-arch support), so the buildpack now checks the architecture where necessary to ensure it continues to operate should it be run against the `arm64` image outside of Heroku. (However, when run on Heroku, this buildpack is still only ever run on `amd64`.) GUS-W-14667590.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for building Python binaries for Heroku-24 using GitHub Actions. Since the Heroku-24 base image supports both
amd64andarm64(to allow for multi-arch CNBs), for Heroku-24 (only) we now also build binaries for both architectures.A later PR will add support for Heroku-24 to the buildpack itself, however, that depends on (a) the Python binaries already having been built, (b) the Heroku build system for Heroku-24 being ready, so those changes are not being made yet.
GUS-W-15571102.