Misc integration test improvements #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
test-improvements
branch
2 times, most recently
from
a5f0fa8 to
6230534
Compare
edmorley
force-pushed
the
test-improvements
branch
2 times, most recently
from
0ace7bb to
b735d3b
Compare
As part of adding Poetry + `.python-version` file support, a fair amount of buildpack refactoring will be required. This backports some of the additional test scenarios we now have in the new Python CNB, along with some test general improvements. It's been split out of later PRs for easier review.
edmorley
force-pushed
the
test-improvements
branch
from
b735d3b to
717145f
Compare
Malax
approved these changes
Sep 23, 2024
Merged
edmorley
added a commit
that referenced
this pull request
Oct 24, 2024
Since Heroku-22 has now been migrated to the new build infrastructure, so no longer has the small system env var differences that were causing these tests to fail on that stack (which is why they had been skipped as part of #1634).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of adding Poetry +
.python-versionfile support, a fair amount of buildpack refactoring will be required.This backports some of the additional test scenarios we now have in the new Python CNB, along with some test general improvements.
It's been split out of later PRs for easier review.
Prep for #796 / #932.
GUS-W-16807487.