Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dotfiles in error message file listings #1728

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Include dotfiles in error message file listings #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Improved the file listing in the error messages shown when buildpack detection fails or when no Python package manager files are found. ([#1728](https://github.com/heroku/heroku-buildpack-python/pull/1728))

## [v272] - 2024-12-13

Expand Down
2 changes: 1 addition & 1 deletion bin/detect
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ directory of its source code.

Currently the root directory of your app contains:

$(ls -1 --indicator-style=slash "${BUILD_DIR}" || true)
$(ls -1A --indicator-style=slash "${BUILD_DIR}" || true)

If your app already has a package manager file, check that it:

Expand Down
2 changes: 1 addition & 1 deletion lib/package_manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function package_manager::determine_package_manager() {

Currently the root directory of your app contains:

$(ls -1 --indicator-style=slash "${build_dir}" || true)
$(ls -1A --indicator-style=slash "${build_dir}" || true)

If your app already has a package manager file, check that it:

Expand Down
Empty file added spec/fixtures/no_python_project_files/.example-dotfile
View file
Open in desktop
Empty file.
Empty file added spec/fixtures/pyproject_toml_only/.example-dotfile
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions spec/hatchet/detect_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
remote: !
remote: ! Currently the root directory of your app contains:
remote: !
remote: ! .example-dotfile
remote: ! README.md
remote: ! subdir/
remote: !
Expand Down
1 change: 1 addition & 0 deletions spec/hatchet/package_manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
remote: !
remote: ! Currently the root directory of your app contains:
remote: !
remote: ! .example-dotfile
remote: ! pyproject.toml
remote: ! subdir/
remote: !
Expand Down