Remove duplicate URL from deprecation message and fix indentation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the duplicate URL + long ling wrapping seen currently: ``` -----> Redis-stunnel app detected ! This buildpack uses stunnel, which isn’t supported on heroku-24 and later. ! You don’t need this buildpack for Redis 6+. Remove it with the command: ! $ heroku buildpacks:remove heroku/redis ! To use Redis’ native TLS support, see https://devcenter.heroku.com/articles/heroku-redis#security-and-compliance: ! https://devcenter.heroku.com/articles/heroku-redis#security-and-compliance ! Push rejected, failed to compile Redis-stunnel app. ```
troycoll
approved these changes
May 31, 2024
mble-sfdc
approved these changes
May 31, 2024
The build system (and other buildpacks) indent one space further for warning messages. This fixes the wonky indentation seen here compared to the last log line (which comes from the build system): Before: ``` -----> Redis-stunnel app detected ! This buildpack uses stunnel, which isn’t supported on heroku-24 and later. ! You don’t need this buildpack for Redis 6+. Remove it with the command: ! $ heroku buildpacks:remove heroku/redis ! To use Redis’ native TLS support, see: ! https://devcenter.heroku.com/articles/heroku-redis#security-and-compliance ! Push rejected, failed to compile Redis-stunnel app. ``` After: ``` -----> Redis-stunnel app detected ! This buildpack uses stunnel, which isn’t supported on heroku-24 and later. ! You don’t need this buildpack for Redis 6+. Remove it with the command: ! $ heroku buildpacks:remove heroku/redis ! To use Redis’ native TLS support, see: ! https://devcenter.heroku.com/articles/heroku-redis#security-and-compliance ! Push rejected, failed to compile Redis-stunnel app. ```
edmorley
force-pushed
the
edmorley/fix-deprecation-message
branch
from
2f15ce9 to
4a1b536
Compare
|
I've also updated the existing indentation, so it matches the style used elsewhere (eg the build system's push failed message): Before: After: |
|
edmorley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the duplicate URL + long ling wrapping seen currently:
GUS-W-15901890.