Stop bundling bootstrap Ruby #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
approved these changes
Jul 9, 2024
Since this buildpack is written in Ruby, it needs a Ruby installation to be installed in order to run. As such, during buildpack compile, a bootstrap Ruby is downloaded installed. As a performance optimisation, this bootstrap Ruby was vendored into the buildpack archive published to the Buildpack Registry, via the `[[publish.Vendor]]` entries in `buildpack.toml`. Since Ruby installs are OS-specific, this meant bundling three copies of Ruby, even though only one would ever be used. With the old build system this was still a net benefit, since the official language buildpacks would be downloaded in advance when a build worker first booted. However, with the new build system architecture, the build system workers are no longer booted en-mass in advance, but instead started on demand. This means there is no worker idle time, and so speculative downloading of possible-needed assets no longer makes sense. As such, the bundling of multiple copies of Ruby in the buildpack registry archive has now been removed. This not only makes non-Ruby builds faster (since they have no need for a Ruby installation at all), but will also speed up Ruby builds, since they'll only need to download one bootstrap Ruby (for their specific stack), rather than a version for every stack.
edmorley
force-pushed
the
edmorley/rm-bundled-ruby
branch
from
2080cd3
to
8ffb1db
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this buildpack is written in Ruby, it needs a Ruby installation to be installed in order to run. As such, during buildpack compile, a bootstrap Ruby is downloaded and installed.
As a performance optimisation, this bootstrap Ruby is vendored into the buildpack archive published to the Buildpack Registry, via the
[[publish.Vendor]]entries inbuildpack.toml. Since Ruby installs are OS-specific, this meant bundling three copies of Ruby, even though only one would ever be used. With the old build system this was still a net benefit, since the official language buildpacks would be downloaded in advance when a build worker first booted.However, with the new build system architecture, the build system workers are no longer booted en-mass in advance, but instead started on demand. This means there is no worker idle time, and so speculative downloading of possibly-needed assets no longer makes sense.
As such, the bundling of multiple copies of Ruby in the buildpack registry archive has now been removed.
This not only makes non-Ruby builds faster (since they have no need for a Ruby installation at all), but will also speed up Ruby builds, since they'll only need to download one bootstrap Ruby (for their specific stack), rather than a version for every stack.
GUS-W-16184923.