-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to oclif core v3 #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved because this looks good, but it looks like you will also need to update the node versions we are running our CI against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I just tested this branch on my new heroku cli plugin, and it works great. The latest oclif generate
scaffolds a structure for the oclif3-compatible plugins only, and the latest stable heroku-cli/command gave me a types mismatch error in TypeScript. Any chances this PR gets merged any time soon? :) I'd really like to release my plugin, though it would be tricky if one of it's dependencies is pulled from Gh repo and should be built right after installing.
Hi @ryandagg! Any chances for this to be merged soon? :) |
Hi @lancedikson I can see you are excited about this (we are too!).. However, there is some other significant work that must be done (primarily with our own plugins) before we can incorporate this into the CLI. The good news is that work has been prioritized and we will be tackling it soon. For now, I'm going to close this PR. |
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001cOMR2YAO/view
Had to update the branch protection rules for master to accommodate the new test names.
https://github.com/heroku/heroku-cli-command/settings/branch_protection_rules/1052008
From
test ($OS-matix, lts/gallium) && test ($OS-matix, lts/fermium)
to
test ($OS-matix, 18.x)