-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delinquency notifications #129
Conversation
I believe the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a well organized and thoroughly tested PR. I left a few comments that are non-blocking. Great work @sbosio!
I must admit that it looked weird to me and I didn't feel strong to make this change as part of the PR, because it felt like too much unrelated. I will add a card for this to our backlog, though to ensure we get to it eventually. Thanks for flagging it @justinwilaby. I don't have a strong background on JS / TS yet to recognize these anti-patterns. |
@justinwilaby Added this work item to GUS for tracking removal of the |
Description
Here we're adding a new feature to the API client implementation in
@heroku-cli/command
where an additional request is done to Particleboard whenever the request URL matches the Account Info endpoint from Platform API (GET /account
), or any endpoint in the Team namespace (GET /teams/:team_id/*
).For this feature we're introducing a new API client for Particleboard with its required configuration and changes to the API client
request
function implementation to match URLs against the patterns of interest and send requests to Particleboard if required to get the delinquency info.Reference RFC
SOC2 Compliance
GUS Work item