Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delinquency notifications #129

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Delinquency notifications #129

merged 7 commits into from
Jun 12, 2024

Conversation

sbosio
Copy link
Contributor

@sbosio sbosio commented Jun 11, 2024

Description

Here we're adding a new feature to the API client implementation in @heroku-cli/command where an additional request is done to Particleboard whenever the request URL matches the Account Info endpoint from Platform API (GET /account), or any endpoint in the Team namespace (GET /teams/:team_id/*).

For this feature we're introducing a new API client for Particleboard with its required configuration and changes to the API client request function implementation to match URLs against the patterns of interest and send requests to Particleboard if required to get the delinquency info.

Reference RFC

SOC2 Compliance

GUS Work item

@sbosio sbosio requested a review from a team as a code owner June 11, 2024 19:58
@sbosio sbosio changed the title Sbosio/delinquency notifications Delinquency notifications Jun 11, 2024
@justinwilaby
Copy link
Contributor

I believe the deps.ts file was created by someone unfamiliar with how node requires dependencies and was intended to cache these for faster access. However, node has been doing this internally for a decade and a half which makes this strategy superfluous. Is there an opportunity to remove this file in favor of the standard import ?

src/api-client.ts Outdated Show resolved Hide resolved
src/api-client.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@zwhitfield3 zwhitfield3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well organized and thoroughly tested PR. I left a few comments that are non-blocking. Great work @sbosio!

@sbosio
Copy link
Contributor Author

sbosio commented Jun 12, 2024

Is there an opportunity to remove this file in favor of the standard import ?

I must admit that it looked weird to me and I didn't feel strong to make this change as part of the PR, because it felt like too much unrelated.

I will add a card for this to our backlog, though to ensure we get to it eventually.

Thanks for flagging it @justinwilaby. I don't have a strong background on JS / TS yet to recognize these anti-patterns.

@sbosio
Copy link
Contributor Author

sbosio commented Jun 12, 2024

@justinwilaby Added this work item to GUS for tracking removal of the deps.ts file.

@sbosio sbosio merged commit 6383da3 into main Jun 12, 2024
3 checks passed
@sbosio sbosio deleted the sbosio/delinquency_notifications branch June 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants