Prepare release workflow for classic buildpacks #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a GitHub Actions workflow for preparing a new "classic" buildpack release. This is based on the workflow that @edmorley added for python (heroku/heroku-buildpack-python#1506). > [NOTE] > This workflow may not be compatible with all of our classic buildpacks such as Ruby or PHP which do not follow the conventions being automated here.
colincasey
added a commit
to heroku/heroku-buildpack-nodejs
that referenced
this pull request
Jan 24, 2024
Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183
colincasey
added a commit
to heroku/heroku-buildpack-nodejs
that referenced
this pull request
Jan 24, 2024
Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183
colincasey
added a commit
to heroku/heroku-buildpack-nodejs
that referenced
this pull request
Jan 24, 2024
Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183
colincasey
added a commit
to heroku/heroku-buildpack-nodejs
that referenced
this pull request
Jan 24, 2024
Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183
edmorley
reviewed
Jan 25, 2024
| # that can be used to make signed commits that are attributed to the GH application user | ||
| token: ${{ steps.generate-token.outputs.app_token }} | ||
|
|
||
| - name: Determine existing published version |
There was a problem hiding this comment.
I have an alternative approach in #184, which uses git tags to calculate the existing version, and so works with Ruby and PHP too.
I've also added support for running a custom command before committing, so the Ruby buildpack can make it's additional edits. (Such as updating the buildpack version in language_pack/version.rb plus moving the changelogs/unreleased/ directory to changelogs/vNNN/ etc)
|
closing this in favor of #184 which includes several improvements |
colincasey
added a commit
to heroku/heroku-buildpack-nodejs
that referenced
this pull request
Jan 26, 2024
* Prepare release automation Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183 * Remove "Buildpack" from workflow name * Always use Title Case for workflow display names --------- Co-authored-by: Ed Morley <[email protected]>
simar0at
pushed a commit
to simar0at/heroku-buildpack-basex
that referenced
this pull request
Feb 14, 2024
* Prepare release automation Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183 * Remove "Buildpack" from workflow name * Always use Title Case for workflow display names --------- Co-authored-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions workflow for preparing a new "classic" buildpack release. This is based on the workflow that @edmorley added for python (heroku/heroku-buildpack-python#1506).
Note
This workflow may not be compatible with all of our classic buildpacks such as Ruby or PHP which do not follow the conventions being automated here.