-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use
--pull-policy if-not-present
when running pack build
Since it: 1. Saves ~2 seconds per integration test re-pulling an image that's already up to date. 2. Helps prevent hitting Docker Hub or ECR rate limits from duplicate (and redundant) image pulling (that counts agains the rate limit even when it's a no-op). Longer term, if Pack CLI supports a periodic pulling mode (buildpacks/pack#1368), we can switch to that, however for now this is the lesser of two evils - and in most cases Pack usage outside of `libcnb-test` will ensure that newer builder images are pulled from time to time. Fixes #306.
- Loading branch information
Showing
3 changed files
with
8 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,17 +60,12 @@ jobs: | |
uses: Swatinem/[email protected] | ||
- name: Install Pack CLI | ||
uses: buildpacks/github-actions/[email protected] | ||
- name: Configure Pack CLI | ||
# Default to a small non-libc image for faster CI + to validate the static musl cross-compilation. | ||
# Adjust pull-policy to prevent redundant image-pulling, which slows CI and risks hitting registry rate limits. | ||
run: | | ||
pack config default-builder cnbs/sample-builder:alpine | ||
pack config pull-policy if-not-present | ||
- name: Run integration tests | ||
# Runs any tests annotated with the `#[ignore]` attribute (which in this repo, are all of the integration tests). | ||
run: cargo test -- --ignored | ||
- name: Compile and package examples/basics | ||
run: cargo run --package libcnb-cargo -- libcnb package | ||
working-directory: ./examples/basics | ||
- name: Pack build using examples/basics | ||
run: pack build example-basics --buildpack target/buildpack/debug/libcnb-examples_basics --path examples/ | ||
# Uses a non-libc image to validate the static musl cross-compilation. | ||
run: pack build example-basics --builder cnbs/sample-builder:alpine --buildpack target/buildpack/debug/libcnb-examples_basics --path examples/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters