Fix starting_containers test after release of Procfile CNB v3.0.0
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Procfile v3.0.0 was just released with an intentional change to the way that `command` vs `args` are handled in the CNB process type definition. This change improves the overall UX, but was breaking in some lesser used scenarios that happened to be tested via the `starting_containers` test in this repo. Specifically, before the `Procfile` file entry would be set as the process `command`, but now it's set as `args`. See: - heroku/buildpacks-procfile#205 (comment) - heroku/buildpacks-procfile@v2.0.2...v3.0.0#diff-782521a81713992d3a07e85975d367cfac60afc78583133551efcddc2026bd3eL19-R20 The tests have been updated to account for the new behaviour, and an additional test added for the "overriding command only" scenario (that wasn't possible to easily test before due to the way the Procfile CNB was previously implemented). Fixes #800. GUS-W-15139634.
colincasey
approved these changes
Feb 28, 2024
Malax
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Procfile CNB v3.0.0 was just released with an intentional change to the way that
commandvsargsare handled in the CNB process type definition. (Before theProcfilefile entry would be set as the processcommand, but now it's set asargs.)That change improves the overall UX of running images that use the Procfile CNB, but is breaking in some lesser used scenarios that happened to be tested via the
starting_containerstest in this repo.See:
The tests have been updated to account for the new behaviour, and an additional test added for the "overriding command only" scenario (that wasn't possible to easily test before due to the way the Procfile CNB was previously implemented).
Fixes #800.
GUS-W-15139634.