Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename gem and namespace everything #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grosser
Copy link

@grosser grosser commented Feb 3, 2017

fixes #19

@geemus

@geemus
Copy link
Contributor

geemus commented Feb 7, 2017

Looks like a great start. Should we add instructions on migrating from the old stuff in the readme?

Also, so we are on the same page about the broader plan of attack. Something like?

  • We will do something with the old gem to either warn or something? I feel like this part might be ambiguous. Given the namespace changes and whatnot, I'm not sure there is a "just works" version. Maybe we should just add a post-install message to the existing gem which says (this is deprecated, please now use this/see these instructions)?
  • We will merge/release this, establishing the first version of the new gem. (depending on what we do with old gem, this might need to come first).

@grosser
Copy link
Author

grosser commented Feb 8, 2017

I think it's pretty obvious what needs to be done to migrate.
post-install messages are annoying ... don't use them for the new gem ... but for the old gem that should be fine.

Always safe to release the new gem.

After that release the old gem with only a dependency to the new gem (maybe with a major version bump) ... and we are done.

@geemus
Copy link
Contributor

geemus commented Feb 15, 2017

@grosser cool, thanks for confirming. We have a couple other related things in flight, but hope to circle back and resolve this relatively soon.

@backus
Copy link

backus commented May 22, 2017

Any update here? Would be much nicer to have the top level namespace be Heroku when using this gem

@grosser
Copy link
Author

grosser commented May 22, 2017

I can rebase if it's ready to be merged ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming the gem
3 participants